harbor icon indicating copy to clipboard operation
harbor copied to clipboard

add DeleteTag support for both aws and azure cr adapters

Open shaiatias opened this issue 4 months ago • 5 comments

I have added support for the DeleteTag operation in AWS ECR and Azure ACR. The operation is currently not supported deleting a tag simply fires a "the tag deletion isn't supported" error.

for AWS, deletion operation is implemented by deleting the tag instead of the manifest so they have the same implementation as delete manifest. For azure, it is done by the untag operation using the delete method for the tag.

Issue being fixed

Fixes #22226

Please indicate you've done the following:

  • [X] Well Written Title and Summary of the PR
  • [X] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • [x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [ ] Made sure tests are passing and test coverage is added if needed.
  • [X] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

shaiatias avatar Aug 05 '25 11:08 shaiatias

@shaiatias the DCO is missing

Vad1mo avatar Aug 05 '25 15:08 Vad1mo

@Vad1mo i pushed --force with dco as in the contribution guide let me know if i did it right

shaiatias avatar Aug 06 '25 08:08 shaiatias

Codecov Report

:x: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.86%. Comparing base (c8c11b4) to head (316ea34). :warning: Report is 604 commits behind head on main.

Files with missing lines Patch % Lines
src/pkg/reg/adapter/azurecr/adapter.go 0.00% 29 Missing :warning:
src/pkg/reg/adapter/awsecr/adapter.go 0.00% 6 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22227       +/-   ##
===========================================
+ Coverage   45.36%   65.86%   +20.49%     
===========================================
  Files         244     1072      +828     
  Lines       13333   115974   +102641     
  Branches     2719     2927      +208     
===========================================
+ Hits         6049    76390    +70341     
- Misses       6983    35351    +28368     
- Partials      301     4233     +3932     
Flag Coverage Δ
unittests 65.86% <0.00%> (+20.49%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pkg/reg/adapter/awsecr/adapter.go 66.03% <0.00%> (ø)
src/pkg/reg/adapter/azurecr/adapter.go 39.68% <0.00%> (ø)

... and 984 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 11 '25 09:08 codecov[bot]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Dec 05 '25 09:12 github-actions[bot]

please do rebase the PR

bupd avatar Dec 05 '25 20:12 bupd