harbor icon indicating copy to clipboard operation
harbor copied to clipboard

Fix: Harbor 2.3: Replication of existing images containing CVEs blocked by the destination project will fail on manifest check early

Open ShaikaJar opened this issue 7 months ago • 3 comments

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Change replication-logic to allow for an error while fetching the manifest of a image, that will be overridden.

Issue being fixed

Fixes #15283

Please indicate you've done the following:

  • [X] Well Written Title and Summary of the PR
  • [ ] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • [x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x] Made sure tests are passing and test coverage is added if needed.
  • [x] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

ShaikaJar avatar May 23 '25 09:05 ShaikaJar

I also thought about changing the ManifestExist specifically for harbor to use the /projects/{project_name}/repositories/{repository_name}/artifacts/{reference} endpoint, but decided against it.

ShaikaJar avatar May 23 '25 09:05 ShaikaJar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.55%. Comparing base (c8c11b4) to head (0244c88). Report is 479 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #22028      +/-   ##
==========================================
+ Coverage   45.36%   46.55%   +1.18%     
==========================================
  Files         244      253       +9     
  Lines       13333    14238     +905     
  Branches     2719     2925     +206     
==========================================
+ Hits         6049     6628     +579     
- Misses       6983     7258     +275     
- Partials      301      352      +51     
Flag Coverage Δ
unittests 46.55% <ø> (+1.18%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 24 '25 11:05 codecov[bot]

@chlins

Please help us review this PR. I think we need to handle it more properly other than skip any error.

reasonerjt avatar May 26 '25 09:05 reasonerjt

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Aug 01 '25 09:08 github-actions[bot]

@chlins
I really need this feature to work. The Issue was open for a really long time Can you please review it (even if you decide this isn't the right solution)

ShaikaJar avatar Aug 01 '25 10:08 ShaikaJar

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Oct 02 '25 09:10 github-actions[bot]

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

github-actions[bot] avatar Nov 02 '25 09:11 github-actions[bot]