harbor
harbor copied to clipboard
Remove unnecessary variables from Makefiles
Comprehensive Summary of your change
-
Makefile
-
Remove
-e
option since it is unnecessary when passing variables as command line arguments tomake -f make/photon/Makefile
. (The-e
option is used to override variables defined in theMakefile
with environment variables.) -
Remove
DEVFLAG
andREGISTRYVERSION
frommake -f make/photon/Makefile
command line arguments since they are unused inmake/photon/Makefile
. -
Add
TRIVYFLAG
tomake -f make/photon/Makefile
command line argument since it is used inmake/photon/Makefile
. Strictly speaking, this argument is unnecessary, but it is better to have it to explicitly indicate thatmake/photon/Makefile
also uses this variable. -
Remove the variable definitions since the following variables are unused.
-
CONFIGPATH
-
CORE_PATH
-
DEVFLAG
-
DOCKERFILEPATH_COMMON
-
GOBUILD
-
GOBUILDMAKEPATH_EXPORTER
-
GOBUILDPATH_EXPORTER
-
GOCLEAN
-
GOCMD
-
GODEP
-
GOFMT
-
GOINSTALL
-
GOTEST
-
PORTAL_PATH
-
PREPAREPATH
-
SRCPATH
-
ZIPCMD
-
-
-
make/photon/Makefile
-
Remove the variable definitions since the following variables are unused.
-
CORE_BINARYNAME
-
CORE_SOURCECODE
-
DOCKERFILENAME_POSTGRESQL
-
DOCKERFILEPATH_POSTGRESQL
-
DOCKERIMAGENAME_POSTGRESQL
-
DOCKERIMAGES
-
JOBSERVICEBINARYNAME
-
JOBSERVICESOURCECODE
-
POSTGRESQL
-
SEDCMD
-
SRCPATH
-
TOOLSPATH
-
WGET
-
-
Remove the variable definitions since the following variables are specified as command line arguments when executed from
Makefile
.-
BASEIMAGENAMESPACE
-
IMAGENAMESPACE
-
-
Issue being fixed
Please indicate you've done the following:
- [x] Well Written Title and Summary of the PR
- [ ] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
- [x] Accepted the DCO. Commits without the DCO will delay acceptance.
- [x] Made sure tests are passing and test coverage is added if needed.
- [ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.