harbor icon indicating copy to clipboard operation
harbor copied to clipboard

[cherry-pick] Limit URL to local site

Open stonezdj opened this issue 1 year ago • 1 comments

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • [x] Well Written Title and Summary of the PR
  • [x] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • [x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x] Made sure tests are passing and test coverage is added if needed.
  • [x] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

stonezdj avatar Feb 23 '24 07:02 stonezdj

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 67.43%. Comparing base (3356196) to head (ebfc4e8).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #20023      +/-   ##
=================================================
+ Coverage          67.41%   67.43%   +0.01%     
=================================================
  Files                993      993              
  Lines             108982   108990       +8     
  Branches            2752     2752              
=================================================
+ Hits               73470    73493      +23     
+ Misses             31553    31537      -16     
- Partials            3959     3960       +1     
Flag Coverage Δ
unittests 67.43% <22.22%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/utils/utils.go 78.13% <100.00%> (+0.20%) :arrow_up:
src/core/controllers/oidc.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

codecov[bot] avatar Feb 23 '24 07:02 codecov[bot]