harbor
harbor copied to clipboard
Move strong_ssl_ciphers to top level in harbor.yml
fixes #19912
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following:
- [x] Well Written Title and Summary of the PR
- [x] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
- [x] Accepted the DCO. Commits without the DCO will delay acceptance.
- [x] Made sure tests are passing and test coverage is added if needed.
- [x] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.45%. Comparing base (
a3e1b1e
) to head (74c8eb1
). Report is 19 commits behind head on main.
:exclamation: Current head 74c8eb1 differs from pull request most recent head 0b7c699. Consider uploading reports for the commit 0b7c699 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #19914 +/- ##
==========================================
- Coverage 67.45% 67.45% -0.01%
==========================================
Files 996 996
Lines 109773 109773
Branches 2720 2720
==========================================
- Hits 74044 74043 -1
- Misses 31747 31750 +3
+ Partials 3982 3980 -2
Flag | Coverage Δ | |
---|---|---|
unittests | 67.45% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
should we take care of these two parts as well
- https://github.com/goharbor/harbor/blob/bca9b14bbfd75e7f7d4c6c9223aaefb76ec07968/make/harbor.yml.tmpl#L37
- https://github.com/goharbor/harbor/blob/bca9b14bbfd75e7f7d4c6c9223aaefb76ec07968/make/photon/prepare/migrations/version_2_10_0/harbor.yml.jinja#L36C1-L57C12
Updated, just need to migrate the 2.10