harbor icon indicating copy to clipboard operation
harbor copied to clipboard

Feat: add acr ee support

Open njucjc opened this issue 1 year ago • 15 comments

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Feat: add acr ee support

Issue being fixed

Fixes #19659

Please indicate you've done the following:

  • [x] Well Written Title and Summary of the PR
  • [x] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • [x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x] Made sure tests are passing and test coverage is added if needed.
  • [x] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

njucjc avatar Dec 01 '23 07:12 njucjc

@AllForNothing @chlins @MinerYang @ctrlaltdel PTAL

njucjc avatar Dec 01 '23 08:12 njucjc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.32%. Comparing base (c8c11b4) to head (f899243). Report is 257 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19658      +/-   ##
==========================================
+ Coverage   45.36%   46.32%   +0.95%     
==========================================
  Files         244      247       +3     
  Lines       13333    13779     +446     
  Branches     2719     2845     +126     
==========================================
+ Hits         6049     6383     +334     
- Misses       6983     7066      +83     
- Partials      301      330      +29     
Flag Coverage Δ
unittests 46.32% <ø> (+0.95%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

codecov[bot] avatar Dec 04 '23 07:12 codecov[bot]

Thanks, @njucjc for your contribution.

I have a couple of basic questions:

  • Is it possible to set up a staging environment of ACR EE for our validation and regression purposes?
  • Also, considering that the replication adapter ships with harbor-core, which requires CVE and bug fixes, would you be responsible for maintaining this adapter?

wy65701436 avatar Dec 04 '23 07:12 wy65701436

Thanks, @njucjc for your contribution.

I have a couple of basic questions:

  • Is it possible to set up a staging environment of ACR EE for our validation and regression purposes?
  • Also, considering that the replication adapter ships with harbor-core, which requires CVE and bug fixes, would you be responsible for maintaining this adapter?

@wy65701436

  • Of course, I can provide an ACR EE instance for regression verification. What is the best way for me to provide this ACR EE instance for you to verify?it has been verified by myself.
  • Sure, It's my honor to maintain this adapter.

By the way, I fix some UTTEST errors

njucjc avatar Dec 04 '23 08:12 njucjc

any comments?

njucjc avatar Dec 07 '23 12:12 njucjc

Thanks, @njucjc for your contribution. I have a couple of basic questions:

  • Is it possible to set up a staging environment of ACR EE for our validation and regression purposes?
  • Also, considering that the replication adapter ships with harbor-core, which requires CVE and bug fixes, would you be responsible for maintaining this adapter?

@wy65701436

  • Of course, I can provide an ACR EE instance for regression verification. What is the best way for me to provide this ACR EE instance for you to verify?it has been verified by myself.
  • Sure, It's my honor to maintain this adapter.

By the way, I fix some UTTEST errors

@wy65701436 I send an ACR EE acount for you in email

njucjc avatar Dec 12 '23 05:12 njucjc

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Feb 11 '24 09:02 github-actions[bot]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Jun 08 '24 09:06 github-actions[bot]

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

@wy65701436 maybe reopen it?

njucjc avatar Jul 11 '24 08:07 njucjc

just a reminder, as discussed please add test cases :)

OrlinVasilev avatar Jul 24 '24 14:07 OrlinVasilev

just a reminder, as discussed please add test cases :)

I will add ut as soon as possible

njucjc avatar Jul 25 '24 11:07 njucjc

lgtm

@chlins fix some ut error.

njucjc avatar Aug 13 '24 06:08 njucjc

@njucjc I watched the demo recording of the community meeting on July 24, 2024. Can you verify that the personal version of ACR is functioning properly at the same time?

kofj avatar Aug 20 '24 10:08 kofj

@njucjc I watched the demo recording of the community meeting on July 24, 2024. Can you verify that the personal version of ACR is functioning properly at the same time?

@kofj Yes, the personal version of ACR can be working well at the same time. image

image

njucjc avatar Aug 21 '24 05:08 njucjc