harbor icon indicating copy to clipboard operation
harbor copied to clipboard

Feat(Logging): create new JSON logger

Open sebglon opened this issue 2 years ago • 10 comments

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Add new formatter for JSON format log. New Env variable to select format type: LOG_FORMAT; value is json for Jsonf format else we use the default text format

Issue being fixed

Fixes #15820

Please indicate you've done the following:

  • [ ] Well Written Title and Summary of the PR
  • [x] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • [x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [ ] Made sure tests are passing and test coverage is added if needed.
  • [x] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

sebglon avatar Jan 30 '23 14:01 sebglon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de6e517) 67.39% compared to head (cf0514f) 44.71%. Report is 343 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18142       +/-   ##
===========================================
- Coverage   67.39%   44.71%   -22.69%     
===========================================
  Files         984      235      -749     
  Lines      106990    13089    -93901     
  Branches     2670     2670               
===========================================
- Hits        72110     5853    -66257     
+ Misses      30999     6943    -24056     
+ Partials     3881      293     -3588     
Flag Coverage Δ
unittests 44.71% <ø> (-22.69%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

codecov[bot] avatar Mar 04 '23 17:03 codecov[bot]

@Vad1mo doc issue is created for tracking

sebglon avatar Apr 14 '23 09:04 sebglon

I was expecting a PR 😂 or an issue with a bit more context that me, you or anybody else knows what to do in a week

Vad1mo avatar Apr 14 '23 15:04 Vad1mo

Hello guys!

@Vad1mo, @OrlinVasilev maybe planning to 2.9?

IwanSE avatar Jun 06 '23 12:06 IwanSE

@sebglon can you please point me to the docs PR ? thanks

OrlinVasilev avatar Jun 07 '23 11:06 OrlinVasilev

@IwanSE - not sure yet @wy65701436 @msha01 @Vad1mo ideas maybe we can discuss it on next community meeting https://github.com/goharbor/community/wiki/Harbor-Community-Meetings

OrlinVasilev avatar Jun 07 '23 11:06 OrlinVasilev

@sebglon would you mind to fix the UI failure? I've marked this as a candidate of v2.10, then we can start review this PR.

wy65701436 avatar Aug 25 '23 04:08 wy65701436

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Oct 24 '23 09:10 github-actions[bot]

@sebglon are you still up for working on this :) it will be great!

OrlinVasilev avatar Oct 24 '23 09:10 OrlinVasilev

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Feb 17 '24 09:02 github-actions[bot]

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

github-actions[bot] avatar Mar 18 '24 09:03 github-actions[bot]