harbor icon indicating copy to clipboard operation
harbor copied to clipboard

Bugfix: add "default"

Open xzxiaoshan opened this issue 3 years ago • 3 comments

Bugfix: If there is no default, the new configuration file is included and cannot run normally, or include will be placed last.

I try to add a server with the same port. Other domain names are processed. The default values that are not modified by default cannot be recognized normally.

Signed-off-by: xzxiaoshan [email protected]

xzxiaoshan avatar Nov 10 '22 03:11 xzxiaoshan

Codecov Report

Merging #17776 (16585d4) into main (77df4d9) will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17776      +/-   ##
==========================================
- Coverage   66.57%   66.56%   -0.02%     
==========================================
  Files         998      998              
  Lines      106918   106918              
  Branches     2597     2597              
==========================================
- Hits        71183    71170      -13     
- Misses      31817    31832      +15     
+ Partials     3918     3916       -2     
Flag Coverage Δ
unittests 66.56% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tegration/tag-retention/tag-retention.component.ts 30.76% <0.00%> (-5.99%) :arrow_down:
...-job/gc-page/gc/gc-history/gc-history.component.ts 40.69% <0.00%> (-5.82%) :arrow_down:
...es/vulnerability/vulnerability-config.component.ts 62.96% <0.00%> (+4.44%) :arrow_up:

codecov[bot] avatar Nov 11 '22 08:11 codecov[bot]

The code that fails the detection has nothing to do with the code I changed. I only modified a small amount.

xzxiaoshan avatar Nov 12 '22 07:11 xzxiaoshan

Could you provide the related nginx document to refer?

MinerYang avatar Nov 14 '22 08:11 MinerYang

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Jan 13 '23 09:01 github-actions[bot]

官方不计划处理吗?

xzxiaoshan avatar Jan 13 '23 09:01 xzxiaoshan

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Mar 15 '23 09:03 github-actions[bot]

Hi @xzxiaoshan, thank you for your contribution. As @MinerYang mentioned earlier, would you please provide us with any link or document that we can use as a reference for this fix? This would be very helpful for us understanding it in deep.

wy65701436 avatar Mar 21 '23 06:03 wy65701436

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

github-actions[bot] avatar Jun 17 '23 09:06 github-actions[bot]