harbor icon indicating copy to clipboard operation
harbor copied to clipboard

Username for External Redis is hardcoded

Open jowko opened this issue 4 years ago • 7 comments

There is no way to configure External Redis username since it is hardcoded as redis. See: {{- define "harbor.redis.url" -}} Historically Redis didn't supported different users, so username didn't mattered. But from version 6.0.0 it can also verify passed username: https://redis.io/commands/auth It would be nice to have an option to configure username too.

jowko avatar Oct 05 '21 14:10 jowko

@jowko I'm going to transfer this issue to the repo goharbor/harbor as this needs the change of harbor

ywk253100 avatar Oct 28 '21 07:10 ywk253100

We considered not to add/support external redis username for Harbor 2.5.0 currently, because redis v6.0+ with AUTH <username> <password> has not been supported in other dependency like github.com/astaxie/beego. beego upgrade issue: https://github.com/beego/beego/issues/4861

MinerYang avatar Feb 11 '22 08:02 MinerYang

Any chance of this being looked at again?

verenion avatar May 05 '22 23:05 verenion

We will keep looking for this. But one thing is that chart-museum is going to deprecated . We need to fully validated and make sure all the components , like trivy should work fine with external redis in using the ACL mode.

MinerYang avatar Jul 14 '22 07:07 MinerYang

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

github-actions[bot] avatar Sep 12 '22 09:09 github-actions[bot]

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

github-actions[bot] avatar Nov 12 '22 09:11 github-actions[bot]

Issue is still not resolved.

jowko avatar Nov 12 '22 09:11 jowko

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

github-actions[bot] avatar Feb 06 '23 09:02 github-actions[bot]

not stale, still an issue

viceice avatar Feb 06 '23 10:02 viceice

https://github.com/goharbor/harbor/issues/18892 DO NOT USE external redis username which would affect distribution performance on push and pulling

MinerYang avatar Jul 12 '23 01:07 MinerYang