harbor-operator icon indicating copy to clipboard operation
harbor-operator copied to clipboard

Make deployments revisionHistoryLimit configurable in harbor Custom resource

Open thcdrt opened this issue 2 years ago • 1 comments

Hello,

By default, deployment parameter revisionHistoryLimit value is set 10 by default. That means that each deployment keeps the 10 last old replicaset.

We would like to reduce it in order to save some ETCD storage.

In Harbor helm chart we can specify it for each component (nginx, portal, core, jobservice...), we would like to have the same parameter in Harbor CR.

WDYT ?

Thomas,

thcdrt avatar Apr 04 '22 15:04 thcdrt

This is the kind of thing that you most probably want to handle globally (if at all) and for that I'd probably write a mutating webhook. The advantage is that you can enforce whatever value you want to use, not just for Harbor.

My two cents.

sagikazarmark avatar Apr 12 '22 15:04 sagikazarmark