harbor-helm icon indicating copy to clipboard operation
harbor-helm copied to clipboard

Closes #979 and implements schedulerName for elements that use persistent storage

Open Jramirezg opened this issue 3 years ago • 4 comments

Closes #979 and implements schedulerName for:

trivy core registry redis jobservice chartmuseum database exporter

Jramirezg avatar Jun 30 '21 15:06 Jramirezg

hi is this PR slove the same issue with #980 ?

ninjadq avatar Jul 08 '21 08:07 ninjadq

@ninjadq yes it does. I put the other pull request and got a comment mentioning that the parameter should be set globally, not per deployment. Closed the #980 now

Jramirezg avatar Jul 21 '21 07:07 Jramirezg

@Jramirezg We are wrapping up for v1.8.0 by mid October, to make the PR merged could you please:

  1. Sign the DCO
  2. Resolve conflict, squash the commit
  3. Clarify the reason for introducing this parameter in the commit message.

reasonerjt avatar Sep 30 '21 07:09 reasonerjt

due to lack of response, moving this PR out of the scope of v1.8.0

reasonerjt avatar Nov 01 '21 06:11 reasonerjt

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions[bot] avatar Feb 08 '24 09:02 github-actions[bot]

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

github-actions[bot] avatar Mar 11 '24 09:03 github-actions[bot]