harbor-helm
harbor-helm copied to clipboard
Workload's labels isn't following the recommendation of labels from Kubernetes.
tl;dr Suggesting Harbor Helm Chart to follow the [Kubernetes Labels Recommendation](backward compatibility).
I'm using Harbor and many apps with helm. And I use their kubernetes labels usefully like;
- Collecting metrics with Prometheus.
- Managing workloads.
But I knew that Harbor Helm has not follwed Kubernetes' label recommendation. (More information)
So I suggest Harbor to follow this recommendation. Or I will commit it by myself, and I'll request for review.
Thank you.
Hi @JhoLee , thank you for mention this, could you help to commit a PR to add this label to harbor-helm, we already have some similar labels but not follow the k8s recommendation, you should keep them and add the new ones. Because some user may depend those labels in production
@ninjadq OK. I'll commit it with backward compatibility.
@ninjadq I committed those labels with backward compatibility!
Hello!! Any update on this?
Yeah, curious as well. Seems like none of the deployments or statefulsets inherit any of these labels. 😢