harbor-helm icon indicating copy to clipboard operation
harbor-helm copied to clipboard

Workload's labels isn't following the recommendation of labels from Kubernetes.

Open JhoLee opened this issue 3 years ago • 5 comments

tl;dr Suggesting Harbor Helm Chart to follow the [Kubernetes Labels Recommendation](backward compatibility).


I'm using Harbor and many apps with helm. And I use their kubernetes labels usefully like;

  1. Collecting metrics with Prometheus.
  2. Managing workloads.

But I knew that Harbor Helm has not follwed Kubernetes' label recommendation. (More information)

So I suggest Harbor to follow this recommendation. Or I will commit it by myself, and I'll request for review.

Thank you.

JhoLee avatar Sep 05 '21 07:09 JhoLee

Hi @JhoLee , thank you for mention this, could you help to commit a PR to add this label to harbor-helm, we already have some similar labels but not follow the k8s recommendation, you should keep them and add the new ones. Because some user may depend those labels in production

ninjadq avatar Sep 16 '21 07:09 ninjadq

@ninjadq OK. I'll commit it with backward compatibility.

JhoLee avatar Sep 17 '21 15:09 JhoLee

@ninjadq I committed those labels with backward compatibility!

JhoLee avatar Sep 21 '21 04:09 JhoLee

Hello!! Any update on this?

martinnirtl avatar Nov 16 '22 10:11 martinnirtl

Yeah, curious as well. Seems like none of the deployments or statefulsets inherit any of these labels. 😢

billabongrob avatar Apr 30 '24 16:04 billabongrob