harbor-helm
harbor-helm copied to clipboard
Ability to include secret instead of exposing raw password
Exposing database and redis secret via helm values files are very dangerous. It would be better to mount k8s secret.
Proposed change (example)
database:
external:
existingSecret: "SECRET-NAME"
existingSecretPasswordKey: "SECRET-KEY"
Also for
-
harborAdminPassword
-
database.internal.password
- etc etc.... you get the idea
Related https://github.com/goharbor/harbor-helm/issues/189
database works , but redis is broken, the docs mention to use a secret, but that's not used
https://github.com/goharbor/harbor-helm/blob/47a3871d9e369670cf70fa4601eaf03ac601de2c/templates/_helpers.tpl#L175 https://github.com/goharbor/harbor-helm/blob/47a3871d9e369670cf70fa4601eaf03ac601de2c/values.yaml#L861
This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.
This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.
Please reopen. This is still an issue. Do i really need to comment every 30 days to have this open? 😕