git icon indicating copy to clipboard operation
git copied to clipboard

Doesn't parse packed refs

Open spheromak opened this issue 9 years ago • 5 comments

Operations only work on repos that have 'loose' refs to tags i.e. have not been GC'd. Probably also goes for packed heads/remotes

spheromak avatar Nov 07 '16 19:11 spheromak

that might be the case of the lower level object implementation but the high level repo.GetTags() will not find any tags if the repo has been gc'd or if it's a fresh checkout of a packed repo.

https://github.com/gogits/git/blob/master/repo_tag.go#L20

On Mon, Nov 7, 2016 at 6:36 PM, Lunny Xiao [email protected] wrote:

It supports packed refs, you can find the code here https://github.com/gogits/git/blob/master/repo_object.go#L73.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gogits/git/issues/27#issuecomment-259028661, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC81BBWpLq4zoKuwCh2e7t5dXd4TvKnks5q7-AWgaJpZM4KroDw .

spheromak avatar Nov 08 '16 02:11 spheromak

@spheromak #28 was just pushed and reworked the handling of packed files. Does this maybe fix this issue?

lemmi avatar Jun 13 '17 22:06 lemmi

Hi, I was wondering if anyone has had time to take a look at my pull request #31 attempting to fix this issue? Thanks

necrophonic avatar Aug 30 '17 09:08 necrophonic

@necrophonic maybe you can also send to https://github.com/go-gitea/git

lunny avatar Aug 30 '17 11:08 lunny

I think #28 fixed it. I went back to using the git bunary in the project I was using this lib with so I haven’t tested it.

spheromak avatar Nov 21 '17 19:11 spheromak