frp-doc icon indicating copy to clipboard operation
frp-doc copied to clipboard

Bump docsy theme to latest version v11.0

Open deining opened this issue 1 year ago • 7 comments

This PR bumps docsy theme to latest released version v11.0. It bumps npm dependencies too and brings some minor cleanup and improvements.

deining avatar Jan 02 '25 08:01 deining

Thank you for your attention, but unless it's absolutely necessary, we don't need to frequently follow up on updates in this area, as it would bring a lot of additional work.

fatedier avatar Jan 02 '25 08:01 fatedier

Thank you for your attention

You are welcome.

but unless it's absolutely necessary, we don't need to frequently follow up on updates in this area,

I see. I won't bother you with any updates in the future 😉

as it would bring a lot of additional work.

  • Upgrade was quite smooth, I wasn't confronted with a lot of work while authoring this PR.
  • anyway, this work was done my me, so it shouldn't bother you!?

Since this PR brings some cleanup, I would like to see this PR merged. But since you are the owner of this repo, the final decision is up to you.

deining avatar Jan 02 '25 08:01 deining

In simple terms, I am not familiar with frontend development. Whenever it involves modifying various packages, I have to manually ensure that no pages or functionalities are broken.

fatedier avatar Jan 02 '25 08:01 fatedier

The Hugo version update also requires changes here: frp-site.

I don’t want to dampen your enthusiasm, so when I have some free time, I’ll thoroughly test and verify it to see if this PR can be merged.

fatedier avatar Jan 02 '25 08:01 fatedier

The Hugo version update also requires changes here: frp-site.

I know. This PR is now in place: https://github.com/gofrp/frp-site/pull/8

Whenever it involves modifying various packages, I have to manually ensure that no pages or functionalities are broken.

I see. I checked a preview of your site and realized that the dark theme switch doesn't work properly any more :-(. Therefore I'm converting this PR to draft status. Give me some time, I will investigate and fix that soon.

I don’t want to dampen your enthusiasm, so when I have some free time, I’ll thoroughly test and verify it to see if this PR can be merged.

Great. For now, the ball is on my side again 🤓

deining avatar Jan 02 '25 09:01 deining

Side note, more or less unrleated: are you interested in a PR that adds the English translation for the website? Time permitting, I may be able to contribute here.

deining avatar Jan 02 '25 09:01 deining

Side note, more or less unrleated: are you interested in a PR that adds the English translation for the website? Time permitting, I may be able to contribute here.

Sure, that's part of the plan. However, I hope to automate this workflow with the help of an LLM instead of relying on long-term manual maintenance. Due to personal time constraints, I haven't been able to dedicate time to this task yet.

fatedier avatar Jan 02 '25 09:01 fatedier

PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close.

github-actions[bot] avatar May 24 '25 02:05 github-actions[bot]