gofr icon indicating copy to clipboard operation
gofr copied to clipboard

Example for interacting with remote file servers

Open RahulMohanK opened this issue 1 year ago • 1 comments

Pull Request Template

Description:

  • This PR aims to add examples for interacting with remote file servers using gofr
  • Closes #990

Additional Information:

  • This PR includes the usage of AddFileStore function to configure a remote file server in gofr and uses the api's available to interact with the remote directory.

Checklist:

  • [x] I have formatted my code using goimport and golangci-lint.
  • [x] All new code is covered by unit tests.
  • [x] This PR does not decrease the overall code coverage.
  • [x] I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

RahulMohanK avatar Sep 28 '24 07:09 RahulMohanK

@RahulMohanK please resolve the review comments given by @srijan-27.

Thankyou

Umang01-hash avatar Oct 04 '24 06:10 Umang01-hash

@srijan-27 @Umang01-hash Resolved the issue with the unit tests. Test coverage of current branch : total: (statements) 88.6% Previously ftp module dependencies for running the example were added into gofr.dev module which was not the right approach. So created a separate module for using-add-filestore to isolate the dependencies.

RahulMohanK avatar Oct 05 '24 19:10 RahulMohanK

@Umang01-hash Refactored test file to increase the readability of the code. Passing logger into function instead of declaring a global variable. Thanks for the comments!!

RahulMohanK avatar Oct 09 '24 19:10 RahulMohanK

@RahulMohanK there are a few review comments left by @aryanmehrotra. Please address them

Umang01-hash avatar Oct 14 '24 04:10 Umang01-hash

@RahulMohanK could you please resolve the review comments left by @aryanmehrotra and @shashank-zopsmart? I think they raised some key code and quality issues with the PR. Thanks for your contribution.

vipul-rawat avatar Oct 28 '24 08:10 vipul-rawat

@RahulMohanK can you address the review changes

vipul-rawat avatar Nov 04 '24 06:11 vipul-rawat

The work of this PR has been addressed in PR #1177. Closing here due to inactivity.

Thankyou for your valuable contribution @RahulMohanK.

Umang01-hash avatar Nov 07 '24 06:11 Umang01-hash