aiac icon indicating copy to clipboard operation
aiac copied to clipboard

Published 20 hours ago • verified publisher icon gofireflyio

feat: create new variables and ignore errors

Open renanbastos93 opened this issue 2 years ago • 2 comments

It was executed golint+gosec so there was improved code. Then it was reduced process in this code like concatenating string directly without the use always fmt.Sprintf, also ignored errors based on old code.

renanbastos93 avatar Jan 21 '23 16:01 renanbastos93

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Jan 21 '23 16:01 ghost

@ido50 @liavyona @eran-infralight @martiGIT Anyone review it, please?

renanbastos93 avatar Jan 24 '23 16:01 renanbastos93

Thanks for your contribution, but we have decided to reject this for now. We will fix all linting issues in the next release. Thanks again.

ido50 avatar Mar 07 '23 12:03 ido50

Thanks for your contribution, but we have decided to reject this for now. We will fix all linting issues in the next release. Thanks again.

No worries, see ya.

renanbastos93 avatar Mar 07 '23 12:03 renanbastos93