template icon indicating copy to clipboard operation
template copied to clipboard

Update to Fiber v3 beta

Open thomasvvugt opened this issue 2 months ago โ€ข 2 comments

Fix for #333

Main issue was the fiber.Map type not coming from gofiber/fiber/v3 but gofiber/fiber/v2.

Summary by CodeRabbit

  • Refactor
    • Updated the underlying web framework to a newer version to enhance performance and security across the application.

thomasvvugt avatar Apr 26 '24 18:04 thomasvvugt

Walkthrough

The overall change involves updating the import path for the fiber package from version 2 to version 3 across multiple Go files. This update reflects a shift to a newer version of the library, likely to take advantage of improved features or compatibility.

Changes

Files Change Summary
django/django.go, django_test.go Updated fiber package import from v2 to v3.
handlebars/handlebars.go, handlebars_test.go Updated fiber package import from v2 to v3.
jet/jet.go Updated fiber package import from v2 to v3.
mustache/mustache.go, mustache_test.go Updated fiber package import from v2 to v3.

Possibly related issues

  • Issue #2879: The change from fiber v2 to v3 could involve updates to the fiber.Ctx interface, which this issue addresses by updating documentation. This PR's changes could be part of the broader interface updates needed.
    • Reasoning: Transitioning to a new major version often includes significant changes that require documentation updates.

๐Ÿ‡โœจ Code leaps through fields of green, From v2 to v3, a change unseen. With every hop, the future's bright, Fiber's new version takes flight. Cheers to code that smoothly runs, Under the watchful eyes of techy buns! ๐Ÿš€๐ŸŒŸ ๐Ÿ‡โœจ


Recent Review Details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits Files that changed from the base of the PR and between 75dc399b2c5e9caa2cdef143d18f40dbca31f47d and c3ee463acc725f6cfd6d8e177b97bcb3be2dd55e.
Files ignored due to path filters (9)
  • django/go.mod is excluded by !**/*.mod, !**/*.mod
  • django/go.sum is excluded by !**/*.sum, !**/*.sum
  • go.mod is excluded by !**/*.mod, !**/*.mod
  • handlebars/go.mod is excluded by !**/*.mod, !**/*.mod
  • handlebars/go.sum is excluded by !**/*.sum, !**/*.sum
  • jet/go.mod is excluded by !**/*.mod, !**/*.mod
  • jet/go.sum is excluded by !**/*.sum, !**/*.sum
  • mustache/go.mod is excluded by !**/*.mod, !**/*.mod
  • mustache/go.sum is excluded by !**/*.sum, !**/*.sum
Files selected for processing (7)
  • django/django.go (1 hunks)
  • django/django_test.go (1 hunks)
  • handlebars/handlebars.go (1 hunks)
  • handlebars/handlebars_test.go (1 hunks)
  • jet/jet.go (1 hunks)
  • mustache/mustache.go (1 hunks)
  • mustache/mustache_test.go (1 hunks)
Files skipped from review due to trivial changes (6)
  • django/django.go
  • django/django_test.go
  • handlebars/handlebars.go
  • handlebars/handlebars_test.go
  • mustache/mustache.go
  • mustache/mustache_test.go
Additional comments not posted (2)
jet/jet.go (2)

12-12: Updated import path to Fiber v3.

This change aligns with the PR's objective to upgrade to Fiber v3.


Line range hint 42-51: Consider improving error handling strategy.

Refer to the previous comment on changing log.Fatalf to returning an error for better error handling.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 26 '24 18:04 coderabbitai[bot]

thx but lets wait for the RC version

ReneWerner87 avatar Apr 26 '24 18:04 ReneWerner87