storage icon indicating copy to clipboard operation
storage copied to clipboard

[Bug] Database password not URL-encoded

Open stenlan opened this issue 3 years ago • 4 comments

Characters such as # and % in my password cause issues. url.QueryEscape-ing my password solves this issue. I don't find this expected behavior because I am not providing a ConnectionURI. When entering a password, I do not expect to be in an environment where I need to manually URL-encode my data.

stenlan avatar Sep 12 '22 21:09 stenlan

Which adapter for which storage are we talking about here?

ReneWerner87 avatar Sep 12 '22 23:09 ReneWerner87

I used postgres

stenlan avatar Sep 14 '22 12:09 stenlan

but we don´t use the QueryEscape method in the password section https://github.com/gofiber/storage/blob/d2569fbe93d9723988a073073019a6c325515ede/postgres/postgres.go#L57-L62

can you try it with https://github.com/gofiber/storage/blob/main/postgres/postgres.go#L51 ConnectionURI direct and give feedback

ReneWerner87 avatar Sep 14 '22 13:09 ReneWerner87

@hi019 do you have an idea how this is possible? Can you help here

ReneWerner87 avatar Sep 14 '22 13:09 ReneWerner87