fiber icon indicating copy to clipboard operation
fiber copied to clipboard

Fix nothing to cache

Open breakbuidl opened this issue 2 years ago • 5 comments

There was no check for nothing to cache if custom expiration < 0. This PR adds that check.

Also, the current implementation checks if expiration < 0 for nothing to cache. However nothing must be cached also in the case expiration = 0. Hence, improved the current implementation to expiration <= 0 for nothing to cache.

breakbuidl avatar May 06 '22 12:05 breakbuidl

@breakbuidl can you check my review comments ?

ReneWerner87 avatar May 16 '22 06:05 ReneWerner87

Hey @ReneWerner87, sorry for the late replay, just got back to this. Will finish this over the weekend.

breakbuidl avatar May 21 '22 06:05 breakbuidl

@breakbuidl any progress on the weekend ?

ReneWerner87 avatar May 24 '22 06:05 ReneWerner87

@breakbuidl?

ReneWerner87 avatar Jun 12 '22 16:06 ReneWerner87

@breakbuidl Friendly bump

gaby avatar Jul 16 '22 19:07 gaby

due to the non-activity, combined with the fact that we don't really see a case for it, because the expiration can't be less than 0 and even if it is, the entry isn't really cached then

so we close the pull request until the code is updated and/or the need is described in more detail

ReneWerner87 avatar Sep 11 '22 11:09 ReneWerner87