contrib icon indicating copy to clipboard operation
contrib copied to clipboard

♻️ fix!: context key collisions

Open sixcolors opened this issue 1 year ago • 3 comments

Fixes context key collisions mentioned in issue https://github.com/gofiber/fiber/issues/2684

related to https://github.com/gofiber/fiber/pull/2781

BREAKING CHANGE

Intended for v3

sixcolors avatar Jan 02 '24 20:01 sixcolors

The FromContext pattern is a lot easier to use! 👍 Are these the only middlewares in this repo that need updating?

nickajacks1 avatar Jan 04 '24 14:01 nickajacks1

The FromContext pattern is a lot easier to use! 👍 Are these the only middlewares in this repo that need updating?

Appears that way. At least in core and contrib. 3rd party middleware were not reviewed.

sixcolors avatar Jan 04 '24 15:01 sixcolors

@ReneWerner87 I created a v3-beta branch, you can merge this into that. (PR set to merge there)

sixcolors avatar Jan 11 '24 21:01 sixcolors