adaptor icon indicating copy to clipboard operation
adaptor copied to clipboard

Adaptor does not implement the hijacker on ResponseWriter

Open R00T99 opened this issue 2 years ago • 5 comments

ResponseWriter does not implement http.Hijacker

More info: github.com/gorilla/websocket/issues/640

R00T99 avatar Aug 03 '21 01:08 R00T99

I would love this feature as well, I'm porting a codebase to fiber and do not want to reimplement all the websocket part for the moment.

kantum avatar Mar 03 '22 18:03 kantum

netHTTPResponseWriter is very simple and does not implement http.Hijacker. I think it's better to open an issue in fasthttp. It's highly recommended to avoid using adaptor.

arsmn avatar Apr 29 '22 22:04 arsmn

@arsmn why is it recommended to avoid adaptor? And by whom?

timo-klarshift avatar Jan 01 '23 13:01 timo-klarshift

Because of performance, by converting to the standard net http request or response, the allocations that fasthttp avoids are used.

ReneWerner87 avatar Jan 01 '23 13:01 ReneWerner87

This should be opened here: https://github.com/valyala/fasthttp/issues

leonklingele avatar May 15 '23 12:05 leonklingele