plex
plex copied to clipboard
goffrie
Rust stable
Hi!
I'm not very familiar with Rust, but very excited by your library. Only my problem is I decided to keep on latest stable Rust. Is it very difficult to support stable Rust at least lexer part?
Hi! It should be possible, but I'm not currently working on it. I'm not very happy with the current options for stable, so I'm going to wait a little at least.
Hi, what's the status on this issue again?
Also, what rust version are you building on? I just encountered a significant number of errors on cargo build's compilation of plex. I'm on Gentoo's nightly branch of rust.
Hi! I'm pretty busy at the moment, so I haven't been actively keeping up to date with Rust master. I'd accept a pull request that works against nightly though ;)
As for stable support... I'd prefer to wait until procedural macros are properly supported in stable, rather than porting it to the syntex/build script approach, which I'm not a fan of.
On Jan 26, 2017 11:44, "Saksham Sharma" [email protected] wrote:
Hi, what's the status on this issue again? Also, what rust version are you building on? I just encountered a significant number of errors on cargo build's compilation of plex. I'm on Gentoo's nightly branch of rust.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/goffrie/plex/issues/13#issuecomment-275439970, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLtTipKPcbN4PkQle3-dGCrHADIcNDoks5rWM17gaJpZM4Kkakb .
Thanks for the quick reply! I'm just starting with rust right now, so perhaps this may be beyond me. But I can try. Update: Initial impressions while fixing => Major changes in rust's syntax crate.
I'm having a look at this now, too. Mostly it just seems to be renaming and some minor reworks of syntax.
I tried it too. Isn't straightforward, since one function/enum now requires u128 type, which is unstable, and doesn't compile. At another point, a function now requires a new argument (Span), which I did not understand. Do let me know if you can make this work. I need this urgently myself. Thanks :smile:
On 27-Jan-2017 3:47 pm, "Yuki Izumi" [email protected] wrote:
I'm having a look at this now, too. Mostly it just seems to be renaming and some minor reworks of syntax.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/goffrie/plex/issues/13#issuecomment-275632604, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ75pKDInkxgwURfJmD5P1CfbYsAFee-ks5rWcQ5gaJpZM4Kkakb .
Down to 5 compile errors (from ~50), so I'll let you know if I get there! 😸
Oh, damn. I wasn't working on the latest master. -_- I'll be a little bit more.
Great! I'll test it out soon. Although, are you informed enough to be able to port it to stable? (In case you would prefer that as well). There's this library rustlex which works on both. Perhaps something like that can be made for this, if possible? I'm quite new to rust, and low on time, so cannot make that work right now. No hurry though :smile:
Unfortunately not; I'm very advanced at Rust either, and I do think it would be a biiiig effort to port this; better waiting for the features to come to stable (or ideally, target nightly yourself).
I wouldn't target a nightly build I'm afraid. But is it safe to assume (from, for instance, here ) that macros 1.1 should be in stable within a week or two? That's what is holding back plex from building on stable, right?
Has anybody built successfully with a stable version compiler?
As long as the procedural macros aren't stabilized yet, I don't think you can build this crate with stable (or even beta).
See this issue for more info: https://github.com/rust-lang/rust/issues/54725
