spartan icon indicating copy to clipboard operation
spartan copied to clipboard

Usage of <hlm-dialog-content> in dynamic content dialog results in endless loop

Open tvollstaedt opened this issue 5 months ago • 3 comments

Please provide the environment you discovered this bug in.

Created a StackBlitz that took the official example and wrapped the dialog content into <hlm-dialog-content>.

Which area/package is the issue in?

accordion

Description

The Dialog component allows the usage with dynamic content by providing a separate component with Dialog's usage. The example on spartan ui shows how to use it this way and makes use of other dialog-related components like <hlm-dialog-header>. However, when using <hlm-dialog-content> as one would presume (also to keep semantic meaning), the Dialog will render itself in an endless loop. Since the example does not make use of <hlm-dialog-content> I guess it's not compatible. This should be either stated with an JS error or within the docs. Neither is the case.

Please provide the exception or error you saw

The dialog renders itself in an endless loop fashion. No error shown or displayed (other then "stack limit exceeded").

Other information

No response

I would be willing to submit a PR to fix this issue

  • [ ] Yes
  • [X] No

tvollstaedt avatar Sep 16 '24 10:09 tvollstaedt