spartan icon indicating copy to clipboard operation
spartan copied to clipboard

Error: No matching export for "DynamicViewModule" in @ngneat/overview package

Open adyngom opened this issue 7 months ago • 2 comments

Please provide the environment you discovered this bug in.

CleanShot 2024-07-13 at 19 22 56

Steps to Reproduce 1. Perform a fresh install of Spartan UI 2. Run the application 3. Observe the error blocking the execution of the entire app

Environment • Spartan UI version: [specify version] • Node.js version: v.22.3.0 • npm version: 10.8.1 • Operating System: MacOs Sonoma 14.3

Additional Context This issue is blocking the execution of the entire application and needs to be addressed for new installations to work properly.

Which area/package is the issue in?

command

Description

On a fresh install of the Spartan UI, the application fails to execute due to an error in the spartan-ng-ui-command-brain component. The error message indicates that there is no matching export for "DynamicViewModule" in the @ngneat/overview package.

Please provide the exception or error you saw

## Error Message
[ERROR] No matching export in "node_modules/@ngneat/overview/fesm2022/ngneat-overview.mjs" for import "DynamicViewModule"
node_modules/@spartan-ng/ui-command-brain/fesm2022/spartan-ng-ui-command-brain.mjs:6:9:
6 | import { DynamicViewModule } from '@ngneat/overview';

Other information

Cause

It appears that DynamicViewModule has been replaced by DynamicViewDirective in a recent update of the @ngneat/overview package.

Proposed Fix

Update the import statement in the spartan-ng-ui-command-brain component:

// Before
import { DynamicViewModule } from '@ngneat/overview';

// After
import { DynamicViewDirective } from '@ngneat/overview';

Additionally, any usage of `DynamicViewModule` within the component should be updated to use `DynamicViewDirective`.

### I would be willing to submit a PR to fix this issue

- [X] Yes
- [ ] No

adyngom avatar Jul 15 '24 05:07 adyngom