spartan icon indicating copy to clipboard operation
spartan copied to clipboard

feat(select): migrate from decorators to signals

Open thatsamsonkid opened this issue 1 year ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

Which package are you modifying?

  • [ ] accordion
  • [ ] alert
  • [ ] alert-dialog
  • [ ] aspect-ratio
  • [ ] avatar
  • [ ] badge
  • [ ] button
  • [ ] calendar
  • [ ] card
  • [ ] checkbox
  • [ ] collapsible
  • [ ] combobox
  • [ ] command
  • [ ] context-menu
  • [ ] data-table
  • [ ] date-picker
  • [ ] dialog
  • [ ] dropdown-menu
  • [ ] hover-card
  • [ ] icon
  • [ ] input
  • [ ] label
  • [ ] menubar
  • [ ] navigation-menu
  • [ ] pagination
  • [ ] popover
  • [ ] progress
  • [ ] radio-group
  • [ ] scroll-area
  • [x] select
  • [ ] separator
  • [ ] sheet
  • [ ] skeleton
  • [ ] slider
  • [ ] sonner
  • [ ] spinner
  • [ ] switch
  • [ ] table
  • [ ] tabs
  • [ ] textarea
  • [ ] toast
  • [ ] toggle
  • [ ] tooltip
  • [ ] typography

What is the current behavior?

All inputs/outputs/viewchild/contentchild etc are all decorator based currently

What is the new behavior?

Migrates all decorators to signal based primitives to prepare for zoneless and match rest of collection of components

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

thatsamsonkid avatar May 26 '24 03:05 thatsamsonkid

This is important

jon9090 avatar Aug 02 '24 11:08 jon9090

Will need to rebase this and finalize the implementation a little later especially with #354 probably getting merged here

thatsamsonkid avatar Aug 21 '24 05:08 thatsamsonkid