spartan icon indicating copy to clipboard operation
spartan copied to clipboard

Add the ability to group buttons

Open ravtakhar opened this issue 1 year ago • 3 comments

Which scope/s are relevant/related to the feature request?

button

Information

I would like to be able to group buttons together and this feature does exist in other frameworks such as Bootstrap: https://getbootstrap.com/docs/5.3/components/button-group/#basic-example

Describe any alternatives/workarounds you're currently using

I am currently not using an alternative

I would be willing to submit a PR to fix this issue

  • [ ] Yes
  • [X] No

ravtakhar avatar Mar 22 '24 18:03 ravtakhar

We actually have something similar. It's called a multi-toggle-group. You can check it out here: https://github.com/goetzrobin/spartan/blob/58c1b34328a5f2528890768d3d30a7d222ea7b29/libs/ui/toggle/toggle.stories.ts#L127

Is this what you're looking for?

goetzrobin avatar Mar 26 '24 15:03 goetzrobin

Hi @goetzrobin 👋

I started Angular 3 years ago and I'm looking to contribute for the first time. I've started using spartan for side projects. I saw this issue with the tag ‘good first issue’.

I analyzed the request and as you said the functionality already exists. However I tried to view the Toggle Group in the storybook but it is empty in the Toogle > Docs.

I also noticed that the Toggle Group doesn't appear in the list of components on the spartan site (spartan.ng/components).

My questions are, can I try to fix the problem in storybook and add the Toggle Group section to the components page? Capture d’écran 2024-07-24 à 18 39 18 Capture d’écran 2024-07-24 à 18 41 31

SantosDylan avatar Jul 24 '24 16:07 SantosDylan

Absolutely @SantosDylan! Go for it!

goetzrobin avatar Jul 24 '24 17:07 goetzrobin