spartan
spartan copied to clipboard
goetzrobin
Displaying the Icon component - adding route and view to spartan-side-nav-links
Which scope/s are relevant/related to the feature request?
Docs
Information
For the presentation site docs & display it would be nice to have a designated Icon display
https://www.spartan.ng/components/icon
Showcasing all icons
- and brand icons, which are either lacking or only partially supported in many UI libraries
Suggestion visualized (using chrome dev tools)
Describe any alternatives/workarounds you're currently using
I only noticed the icon component as I was exploring the button component, and and after installing, viewers who have not used the UI library yet may assume there isn't an icon component
I would be willing to submit a PR to fix this issue
- [X] Yes
- [ ] No
@monacodelisa good point we should have a page for it. Will you be doing a PR for this else I think this enhancement could also make a "good first issue" for someone
hi @thatsamsonkid, for every issue that I write know that I would be happy to submit a PR. This one I was thinking to do it in one PR together with #219. Having said that I also do not want to hover over issues and I do agree it makes a good first issue. Considering the total amount of open issues - it does make sense to keep it open and give others the opportunity to work on it. So maybe keep it open, but after a while if there is no activity you can assign it to me.
Awesome, sorry for all the comments, really just wanted to double check make sure you hadn't already made progress or was about to open PR as well for these issues. But agreed for the 2 issues if some time passes and no bites feel free to do them. Thanks!
Hello, I'm considering to implement this feature, what is the expected UI of the Icon Component?
Hi @DevWedeloper so this is actually to create the docs page for the icon component we have in the lib. The components to set up the page are there so its mainly to create the page and add some content for icon component preview installation and usage
@DevWedeloper it is great that you are asking for clarification, I believe that things as UI should always be discussed, maybe you want to come over and teach my contributors a thing or two :)
It is totally up to you now, but what I had in mind was displaying all the available icons, and adding a search bar. Similar to the way that it's done by Google Material Icons, PrimeNG and other UI libraries.
Interestingly enough this is absent in Angular Material but that is only because it would be the same as Google Material Icons.
I was also thinking of removing the example usage of a single icon from the button section and showing example usage per selected icon - after the search, or on click.
This is just something that I find more practical when I use a UI library I like to be able to quickly get the icon that I need, instead of wondering what icons may or may not be available.
Further on - I was thinking of doing this because when the available icons are displayed like this it is easy to see what icons are missing and more can be added, I was thinking of adding more. (later on)
Just me sharing my thoughts.
I also thought of adding a search bar. Anyways I made a PR #251, I'm also considering adding a copy to clipboard (copy icon name) mechanics? But for now I would wait for feedbacks
