spartan icon indicating copy to clipboard operation
spartan copied to clipboard

peer dependency conflicts with clsx

Open dez1729 opened this issue 1 year ago • 3 comments

Please provide the environment you discovered this bug in.

ui/core 0.0.1-alpha.336

Which area/package is the issue in?

Don't know / other

Description

It seems that the installed version of clsx which is 1.2.1 conflicts with the current version which is 2.1.0. As a result, any npm updates fail unless using --force.

image

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

  • [ ] Yes
  • [X] No

dez1729 avatar Mar 14 '24 20:03 dez1729

Hey @dez1729! Have you had clsx installed before or was it installed as part of the spartan CLI setup?

goetzrobin avatar Mar 18 '24 20:03 goetzrobin

i installed clsx in my project separately which is the reason the conflict occurred. I would need it installed to use clsx on the installed spartan packages correct?

dez1729 avatar Mar 25 '24 16:03 dez1729

yes. the CLI installs the correct version for you, but if your project already uses clsx then it might cause conflicts. Let me see what breaking changes were introduced and if it's a good idea for bumping up the version in general

goetzrobin avatar Mar 26 '24 22:03 goetzrobin