spartan icon indicating copy to clipboard operation
spartan copied to clipboard

Published 20 hours ago • verified publisher icon goetzrobin

RFC: Slider

Open goetzrobin opened this issue 1 year ago • 6 comments

Which scope/s are relevant/related to the feature request?

slider

Information

TBD

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • [X] Yes
  • [ ] No

goetzrobin avatar Jan 11 '24 20:01 goetzrobin

This should be an adaption of the CDK slider: https://github.com/angular/components/blob/main/src/material/slider/slider.ts

I like the API surface and we should be able to split it into brain and hlm pretty cleanly

goetzrobin avatar Feb 28 '24 22:02 goetzrobin

@goetzrobin are y working on this? If not, can I take it over?

tsironis13 avatar Jun 30 '24 12:06 tsironis13

@tsironis13 go ahead! I assigned it to you!

goetzrobin avatar Jun 30 '24 13:06 goetzrobin

@goetzrobin hello! I am trying to push the first initial draft version of the slider component but it seems that I do not have permissions to do so... image

tsironis13 avatar Jul 08 '24 08:07 tsironis13

@goetzrobin is this task finished? I can see the slider in the internal storybook, but has not been published yet. Also, it seems a bit laggy or over-animated compared to shadcn.

marcindz88 avatar Sep 12 '24 15:09 marcindz88

@goetzrobin is this task finished? I can see the slider in the internal storybook, but has not been published yet. Also, it seems a bit laggy or over-animated compared to shadcn.

@marcindz88 it has been merged to main https://github.com/goetzrobin/spartan/pull/328

tsironis13 avatar Oct 02 '24 06:10 tsironis13

@tsironis13 I can see that, but its brain is not published and slider is not present in docs...

marcindz88 avatar Oct 13 '24 20:10 marcindz88

Hi @goetzrobin Could you publish this feature? Or is it not ready yet?

marcindz88 avatar Oct 28 '24 17:10 marcindz88