spartan icon indicating copy to clipboard operation
spartan copied to clipboard

fix: healthcheck for toggle-group/collapsible ignore helm files

Open marcjulian opened this issue 2 weeks ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/spartan-ng/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

Which package are you modifying?

Primitives

  • [ ] accordion
  • [ ] alert
  • [ ] alert-dialog
  • [ ] aspect-ratio
  • [ ] autocomplete
  • [ ] avatar
  • [ ] badge
  • [ ] breadcrumb
  • [ ] button
  • [ ] button-group
  • [ ] calendar
  • [ ] card
  • [ ] carousel
  • [ ] checkbox
  • [ ] collapsible
  • [ ] combobox
  • [ ] command
  • [ ] context-menu
  • [ ] data-table
  • [ ] date-picker
  • [ ] dialog
  • [ ] empty
  • [ ] dropdown-menu
  • [ ] field
  • [ ] form-field
  • [ ] hover-card
  • [ ] icon
  • [ ] input
  • [ ] input-group
  • [ ] input-otp
  • [ ] item
  • [ ] kbd
  • [ ] label
  • [ ] menubar
  • [ ] navigation-menu
  • [ ] pagination
  • [ ] popover
  • [ ] progress
  • [ ] radio-group
  • [ ] resizable
  • [ ] scroll-area
  • [ ] select
  • [ ] separator
  • [ ] sheet
  • [ ] sidebar
  • [ ] skeleton
  • [ ] slider
  • [ ] sonner
  • [ ] spinner
  • [ ] switch
  • [ ] table
  • [ ] tabs
  • [ ] textarea
  • [ ] toggle
  • [x] toggle-group
  • [ ] tooltip
  • [ ] typography

Others

  • [ ] trpc
  • [ ] nx
  • [ ] repo
  • [ ] cli

What is the current behavior?

closes #998

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

Other information

marcjulian avatar Nov 13 '25 14:11 marcjulian

Migration may end up like this, need to add a test case for this. Also need to ignore helm toggle files for healthcheck to trigger.

- import {
- BrnToggleGroup,
- BrnToggleGroupItem,
-} from '@spartan-ng/brain/toggle-group';
+import {} from '@spartan-ng/brain/toggle-group';

marcjulian avatar Nov 13 '25 15:11 marcjulian

Migration may end up like this, need to add a test case for this. Also need to ignore helm toggle files for healthcheck to trigger.

- import {
- BrnToggleGroup,
- BrnToggleGroupItem,
-} from '@spartan-ng/brain/toggle-group';
+import {} from '@spartan-ng/brain/toggle-group';

should we add a test case to make sure this is covered?

goetzrobin avatar Nov 14 '25 12:11 goetzrobin