Asmir Mustafic

Results 538 comments of Asmir Mustafic

`somenamespace\DocumentCodeType` in the YAML it is a bug, it should be `string`. In your case `DocumentCodeContentType` extends `xs:token` that is a string. The issue is somewhere in https://github.com/goetas-webservices/xsd2php/blob/5e5f02645da79bc4febfeb9a47cd4760861b2577/src/Jms/YamlConverter.php#L403C31-L403C31 but might...

i would make this an opt-in feature. it has serious performance implications as it has to check the same thing for the potential parent classes

ah, now i have noticed that this is for 2.x

@mbabker thanks for the great work as usual! (and @alexander-schranz thanks for pinging me on this)

Thanks for the exceptional quality of work! Released as 3.7.0 https://github.com/FriendsOfSymfony/FOSRestBundle/releases/tag/3.7.0

Could you please explain what is this change for?

I'm willing to accept such feature/bug-fix, but I think that is pretty hard to implement. Making the diff of a doctrine collection can be quite hard.

> @goetas I think it might be enough to reuse the existing ArrayCollection, even if we call clear before assigning the new values. > I tried to implement that, but...

@re2bit hi, sorry for the delay. I had a look at your implementation, i think that is too much added complexity for such edge-case (maybe for some is not ad...

~~@re2bit now that i've read better the doctrine issue, can [this](https://github.com/doctrine/orm/issues/6999#issuecomment-461090286) be the solution?~~ nvm, that is what you were doing...