Asmir Mustafic

Results 542 comments of Asmir Mustafic

It would be great if you could provide a fix for this DX issue. I think that a good place to start is https://github.com/schmittjoh/serializer/blob/0edb562707c032156516fe94d27d0f685032573f/src/Metadata/Driver/AnnotationDriver.php#L272 you could add a check that...

I think that you can copy the files from the serializer (https://github.com/schmittjoh/serializer/blob/master/doc/conf.py)

https://github.com/schmittjoh/serializer/pull/997 implemented the document build on the serializer library

> an obvious solution is to write a custom visitor implementing visitNull. Why not just implement a custom exclusion strategy? This (https://github.com/schmittjoh/serializer/pull/790) has been merged recently.. can it be helpful?

Currently this library does not offer such feature, but you can have a look to https://github.com/gam6itko/jms-serializer-config-converter that does it

This issue is not related to PHP 7.2 and neither to yiisoft/yii#4167. It is more related to DX. The error is thrown because of some wrong syntax in `$entryName`. In...

> So if it's false, an error have to be thrown ? yes. there is no right "default" behavior the lib could do except of throwing an error.

Do not know it the error was thrown for that reason... I think the error was in `$entryName`.. wasn't?

You have created the ticker in the wrong repo :) (that's why I have added the "serializer issue" label) The ticket should have been opened on https://github.com/schmittjoh/serializer. Into that library...

Please note that most likely you will have to submit your PR to the `1.x` branch.