Add net8.0 and use Regex source generator

[martincostello]

• Add target for net8.0 and update to C# 12.
• Use the Regex source generator via [GeneratedRegex] when targeting net8.0.
• Bump the checkout and setup-dotnet actions to v4 to fix warnings about deprecated Node.js versions.
• Remove invalid key from NuGet publishing workflow.

[pull-request-quantifier-deprecated[bot]]

This PR has 208 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Large
Size       : +160 -48
Percentile : 60.8%

Total files changed: 7

Change summary by file extension:
.yml : +4 -5
.props : +2 -2
.csproj : +2 -2
.cs : +151 -38
Dockerfile : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

[martincostello]

Is this worth changing to 0.2 for the new TFM?

https://github.com/goelhardik/ignore/blob/5d53183feebe4430bd84050d9cc1494be53b59d4/version.json#L3

[goelhardik]

Is this worth changing to 0.2 for the new TFM?

https://github.com/goelhardik/ignore/blob/5d53183feebe4430bd84050d9cc1494be53b59d4/version.json#L3

@martincostello yeah I think it's a good idea, we can bump to 0.2