Sevket Gökay
Sevket Gökay
@fnkbsi i see you made some changes after my comment. are these changes in reaction to my remarks? if yes, are you finished? is this PR stable now?
thanks! migration file LGTM. i think you can even remove the `GRANT SUPER ...` privileges from CI and from the [readme here](https://github.com/steve-community/steve?tab=readme-ov-file#configuration-and-installation).
> Without the Super privileges the workflow does not run successful. ... because the view creation dictates `steve@localhost` as definer which is not necessarily needed. - see [this](https://stackoverflow.com/questions/13492857/create-view-without-super-privileges-in-phpmyadmin) - [my...
@fnkbsi should i merge or do you want to? i approved the PR to signal that you can merge it.
thanks all!
hey @fnkbsi are these changes finished and stable?
what is the state of this PR after merging #1439 ?
i am closing this issue due to inactivity. feel free to reopen if it is still relevant.
> as far as i remember it will not return "accepted" to a chargepoint if the ocpp tag is not in its "Ocpp tag" list this is true. therefore, i...
> The code also suggests it was supposed to be the case that all transactions (and not just the active ones) would be shown. i guess you are referring to:...