godwoken icon indicating copy to clipboard operation
godwoken copied to clipboard

Published 20 hours ago • verified publisher icon godwokenrises

BREAKING CHANGES: remove withdrawal locked cell

Open zeroqn opened this issue 2 years ago • 10 comments

In this pr, we remove withdrawal locked cell generation and generate user unlocked cell directly, according to godwoken-scripts upgrade from pr https://github.com/nervosnetwork/godwoken-scripts/pull/126.

Visit https://github.com/nervosnetwork/godwoken-scripts/pull/126 for more detail.

Primary changes:

  • remove withdrawal locked cell generation
  • remove all finalized custodian query check for withdrawal request verification
  • deprecate withdrawal locked cell revert and unlock to owner code
    • we can remove these after unlock all withdrawals
  • implement RollupFinalizeWithdrawal action
  • add WithdrawalFinalizer to runner loop, it will update last_finalize_withdrawal queue when available.

zeroqn avatar Sep 13 '22 12:09 zeroqn

Running integration test

Workflow Run Id: 3045252101

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Sep 13 '22 12:09 gw-bot[bot]

Running integration test

Workflow Run Id: 3046352721

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Sep 13 '22 15:09 gw-bot[bot]

Running integration test

Workflow Run Id: 3046931286

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Sep 13 '22 16:09 gw-bot[bot]

Running integration test

Workflow Run Id: 3050008419

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Sep 14 '22 03:09 gw-bot[bot]

/itest scripts: 3aed9a9e10112a9e5268609c105e2b24769c6c47

zeroqn avatar Sep 14 '22 04:09 zeroqn

Running integration test

Workflow Run Id: 3050100111

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Sep 14 '22 04:09 gw-bot[bot]

Running integration test

Workflow Run Id: 3241592968

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Oct 13 '22 10:10 gw-bot[bot]

Running integration test

Workflow Run Id: 3242745181

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Oct 13 '22 13:10 gw-bot[bot]

Running integration test

Workflow Run Id: 3246979545

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Oct 14 '22 02:10 gw-bot[bot]

Running integration test

Workflow Run Id: 3247068911

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot[bot] avatar Oct 14 '22 02:10 gw-bot[bot]

This PR should be retarget to next script upgrade.

Related PR https://github.com/godwokenrises/godwoken-scripts/pull/126

jjyr avatar Nov 03 '22 05:11 jjyr