php-snowflake icon indicating copy to clipboard operation
php-snowflake copied to clipboard

Add second-level timestamp bit

Open hafung opened this issue 2 years ago • 5 comments

hafung avatar Jul 06 '22 03:07 hafung

thank your PR, but could you please update the PR description detail? I don't know what this PR does.

Also, please fix the CI error.

godruoyi avatar Jul 06 '22 04:07 godruoyi

#34

godruoyi avatar Jul 06 '22 05:07 godruoyi

It looks like it provides a 53bit snowflake ID implementation If I understand it right, hmm... I don't think I can accept it because it's too limiting, maybe only you need this; so do you plan to make it more flexible?

Anyway, thanks for your PR, and if you just want to implement a 53bit snowflake ID, I suggest you go ahead and do it directly in your owner project. thanks.

godruoyi avatar Jul 06 '22 05:07 godruoyi

Codecov Report

Merging #35 (7cd00af) into master (ec2eb7f) will decrease coverage by 3.04%. The diff coverage is 86.95%.

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
- Coverage     99.28%   96.23%   -3.05%     
- Complexity       51       66      +15     
============================================
  Files             6        7       +1     
  Lines           140      186      +46     
============================================
+ Hits            139      179      +40     
- Misses            1        7       +6     
Impacted Files Coverage Δ
src/IceFlake.php 86.95% <86.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec2eb7f...7cd00af. Read the comment docs.

codecov-commenter avatar Jul 06 '22 06:07 codecov-commenter

It looks like it provides a 53bit snowflake ID implementation If I understand it right, hmm (嗯) ... I don't think I can accept it because it's too limiting, maybe only you need this; so do you plan to make it more flexible?

Anyway, thanks for your PR, and if you just want to implement a 53bit snowflake ID, I suggest you go ahead and do it directly in your owner project. thanks.

okay... make sense indeed... i thought i just add a stand-alone option, it would do no harm. anyway, that's fine

hafung avatar Jul 06 '22 08:07 hafung