godot icon indicating copy to clipboard operation
godot copied to clipboard

SCons: Address minor `show_progress` issues

Open Repiteo opened this issue 1 year ago • 2 comments

  • Followup to #98154

Realized a minor regression introduced by the above PR causing node count to not be tracked whatsoever if not displaying a progress bar. Additionally, progress_finish as an SCons action is unnecessary & doesn't catch all cases; it's now handled via atexit like the cache cleaning

Repiteo avatar Nov 15 '24 17:11 Repiteo

LGTM

hpvb avatar Dec 10 '24 02:12 hpvb

Is it about a fact that [Initial build] disappeared recently or something else?

dustdfg avatar Dec 15 '24 15:12 dustdfg

Is it about a fact that [Initial build] disappeared recently or something else?

That being removed was deliberate, but this PR makes sure that it will only happen on an initial build

Repiteo avatar Dec 16 '24 20:12 Repiteo

Needs rebase.

akien-mga avatar Dec 17 '24 15:12 akien-mga

Thanks!

akien-mga avatar Dec 17 '24 22:12 akien-mga