godot icon indicating copy to clipboard operation
godot copied to clipboard

Revert "Fix GPUParticles are not rendered for older AMD GPUs with OpenGL+Angle"

Open clayjohn opened this issue 1 year ago • 1 comments

Fixes: https://github.com/godotengine/godot/issues/96943 Fixes: https://github.com/godotengine/godot/issues/97875

This reverts commit 9cc9df52eb6ef32b80bd3bd725807fea70b00a89.

Maybe Reintroduces: https://github.com/godotengine/godot/issues/95797

We tested https://github.com/godotengine/godot/pull/96413 very carefully and Maran23 did a very detailed investigation, but this change has broken more projects than it fixed, so we need to revert for now and try again with something else.

clayjohn avatar Oct 18 '24 23:10 clayjohn

@Maran23 Could you test this on your device that reproduces https://github.com/godotengine/godot/issues/95797

I have just pushed with another commit that removes the polyfill when running with ANGLE based on a comment you made in https://github.com/godotengine/godot/issues/95797#issuecomment-2317052291. I'm hoping that this will be enough to solve the bug you ran into while still keeping good behaviour on other devices

clayjohn avatar Oct 18 '24 23:10 clayjohn

Thank you for tackling this issue, as I am pretty clueless what to try next. Your idea with the ifdef looks promising. I can and will test this next week!

Maran23 avatar Oct 19 '24 10:10 Maran23

Tested and it works perfectly fine now.

To be sure, we did the following:

  • Tested Godot 4.3: Broken
  • Tested Godot 4.4dev3: Works
  • Tested this PR: Works

Maran23 avatar Oct 28 '24 19:10 Maran23

Awesome! Thank you for checking. I'll squash the commits in this PR and then we can merge it.

clayjohn avatar Oct 28 '24 21:10 clayjohn

Thanks!

Repiteo avatar Nov 01 '24 01:11 Repiteo