godot
godot copied to clipboard
godotengine
Fix touch screen events on Linux being misattributed to the main window
Simple test case: TouchTestCaseSrc.zip
System info on the machine i tested with
Operating System: Arch Linux KDE Plasma Version: 6.1.5 KDE Frameworks Version: 6.6.0 Qt Version: 6.7.3 Kernel Version: 6.11.1-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 7 5825U with Radeon Graphics Memory: 15.0 GiB of RAM Graphics Processor: AMD Radeon Graphics Manufacturer: Dell Inc. Product Name: Inspiron 16 5625 System Version: 1.10.0
Fixes #77653
I would like to ask you to split your PR into two separate PRs, one for each bug. This would make it easier to review each change and would make it easier to handle regressions.
I would like to ask you to split your PR into two separate PRs, one for each bug. This would make it easier to review each change and would make it easier to handle regressions.
I split off the mouse emulation fix to another pr #98318 . That being said, the windows users(for who mouse emulation goes to the wrong window) in #77653 are not experiencing the same bug as the Linux users (who straight up don't receive the touch events in the right window)
Can't reproduce the issue, tested on PopOS 22.04 with touchscreen and Wacom table. It seems to work the same with or without this change.
Heres a recording of the issue before and after the fix
https://github.com/user-attachments/assets/b576c0fa-5d04-4a5c-87eb-b634fd56a4db
https://github.com/user-attachments/assets/1afc9098-f78f-4d22-84f8-17ddd3727aeb
You mentioned that this fixes the linked issue, but your title only talks about Linux. Does it address the issue for both OS? I'm going to compile it later today and see if it fixes my issue
Update: does not fix https://github.com/godotengine/godot/issues/77653. This PR is entirely unrelated to the issue