Fix updating dynamic objects in LightmapGI

Open huwpascoe opened this issue 1 year ago • 2 comments

Fixes https://github.com/godotengine/godot/issues/77167

Minimal reproduction project: test_lightmapgi_dynamic_object_update.zip

Oct 07 '24 12:10 huwpascoe

Made the changes. It works for all three scenarios: scene load, visibility change, rebake.

Oct 17 '24 15:10 huwpascoe

Works with the new MRP https://github.com/godotengine/godot/issues/77167#issuecomment-2419764911

Oct 18 '24 19:10 huwpascoe

Thanks! Congratulations on your first contribution!

Oct 21 '24 21:10 Repiteo

Is this getting cherry picked?

Nov 14 '24 04:11 atirut-w

Is this getting cherry picked?

Good reminder. It wasn't tagged to be cherry picked. But I think it can be

Nov 14 '24 06:11 clayjohn