godot icon indicating copy to clipboard operation
godot copied to clipboard

Remove note about missing per-vertex-shading

Open TheYellowArchitect opened this issue 1 year ago • 1 comments

Followup to https://github.com/godotengine/godot/pull/83360

TheYellowArchitect avatar Oct 07 '24 11:10 TheYellowArchitect

Nice catch! :+1:

TheYellowArchitect avatar Oct 07 '24 18:10 TheYellowArchitect

Changes look good to me. The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that.

mhilbrunner avatar Oct 08 '24 15:10 mhilbrunner

And please update your commit message to be more descriptive, the title of the PR would be appropriate, using git commit --amend (after squashing)

AThousandShips avatar Oct 08 '24 15:10 AThousandShips

Thank you both for the suggestions. I didn't expect the rebase to be that easy (instead of upstream/master basically master lol), nor that I can git commit --amend after doing a git push --force.

TheYellowArchitect avatar Oct 17 '24 18:10 TheYellowArchitect

Thanks! Congratulations on your first contribution! 🎉

Repiteo avatar Nov 10 '24 18:11 Repiteo