godot icon indicating copy to clipboard operation
godot copied to clipboard

Editor: Use `HFlowContainer` to display file dialog options

Open HolonProduction opened this issue 1 year ago • 2 comments

Followup to #80561 which improves the UI a bit:

Before

Screenshot from 2024-09-06 11-42-54

After

Screenshot from 2024-10-06 18-37-09

Since we are not using a grid container anymore I also switched to using the checkbox label instead of an additional one. This improves usability a bit since the text is now also a click target.

HolonProduction avatar Oct 06 '24 16:10 HolonProduction

Related to #95304 and #95140 I think the options were vertical to be more consistent with native dialogs. CC @bruvzg

KoBeWi avatar Oct 07 '24 20:10 KoBeWi

It depends on the platform, on Linux (at least GTK) it's also horizontal. So it should be file, as long as both checkbox and dropdown options look OK.

bruvzg avatar Oct 07 '24 21:10 bruvzg

Dropdowns still work and also the label can't be on another line than the dropdown. Only point that might be somewhat controversial is that dropdowns show the label and then the dropdown while checkboxes show the checkbox and then the label.

I looked at Gnome for inspiration regarding this and they do it exactly the same, so it should be fine, especially since there are no dropdowns in the codebase at the moment (plugins might use them though).

HolonProduction avatar Oct 08 '24 16:10 HolonProduction

This can resolve #95079 if the same change is done for FileDialog.

EDIT: Well that issue is about editor-only, just the same bug applies to FileDialog too.

KoBeWi avatar Oct 15 '24 15:10 KoBeWi

Only point that might be somewhat controversial is that dropdowns show the label and then the dropdown while checkboxes show the checkbox and then the label.

Same on Windows. It's not the case only on macOS, but on macOS we can change this as we want:

Screenshot Windows Screenshot macOS

bruvzg avatar Oct 15 '24 15:10 bruvzg

Closing since #99182 was merged

HolonProduction avatar Jan 13 '25 10:01 HolonProduction