godot icon indicating copy to clipboard operation
godot copied to clipboard

Create and add icons to Scripts Editor scripts panel context menu items

Open ev13bird opened this issue 1 year ago • 4 comments

Rework of #97306. I've split up the work into individual PRs for a simpler merging process.

For accessibility purposes and consistency with the Scene dock's node context menu, this PR adds icons to the Scripts Editor's scripts panel context menu: scripts_context_menu

Some menu items do not have existing appropriate icons, so this PR also adds several new icons:

  • SaveAs.svg SaveAs
  • SidePanel.svg SidePanel
  • HelpClose.svg HelpClose
  • ListCloseAll.svg ListCloseAll
  • ListCloseOthers.svg ListCloseOthers

I've tried following the documentation's guidelines on creating new icons, but please do feel free to suggest improvements!

ev13bird avatar Oct 06 '24 15:10 ev13bird

scripts_context_menu

My opinion is the same as before: having icons for every menu item is overcrowded. It also weakens the ability to quickly locate menu items by their icons. It would be better to have icons only for representative (frequently used) menu items.

timothyqiu avatar Oct 06 '24 15:10 timothyqiu

Thanks for the suggestion! Which icons do you think should be kept vs removed? I believe @KoBeWi suggested filling more of them out, but I can see it being too overcrowded as well.

ev13bird avatar Oct 06 '24 16:10 ev13bird

Which icons do you think should be kept vs removed?

For example, I think that

  • groups like Save* and Close* only needs to have one icon, and
  • not frequently used items don't need to have an icon.

image

timothyqiu avatar Oct 07 '24 01:10 timothyqiu

Fixed, thank you!

new_scripts_context_menu

ev13bird avatar Oct 07 '24 14:10 ev13bird