godot icon indicating copy to clipboard operation
godot copied to clipboard

Add unit tests for `ReflectionProbe`

Open Gurka2 opened this issue 1 year ago • 4 comments

Added tests for the class Reflection Probe

The tests test the class getters and setters and the function get aabb. This is what was asked in the issue https://github.com/godotengine/godot/issues/43440.

Gurka2 avatar Oct 04 '24 16:10 Gurka2

There is one problem. You used merge commit instead of rebasing

dustdfg avatar Oct 04 '24 17:10 dustdfg

When this has been reviewed it will need to be squashed, but please use rebase in the future instead, see here

AThousandShips avatar Oct 04 '24 17:10 AThousandShips

I will fix the commit history some time next week :+1: :slightly_smiling_face:

Gurka2 avatar Oct 04 '24 17:10 Gurka2

@dustdfg @AThousandShips I think i fixed the git merge now :slightly_smiling_face: I configured the git config to rebase aswell

Gurka2 avatar Oct 07 '24 09:10 Gurka2