godot icon indicating copy to clipboard operation
godot copied to clipboard

Fix `CPUParticles3D` to `GPUParticles3D` weird particle conversion behavior

Open PrIzRaKDev opened this issue 1 year ago • 5 comments

This is A LIKELY fix to the problem #97621. (It needs to be assembled and tested)

Bugsquad edit:

  • Fix #97621

PrIzRaKDev avatar Sep 30 '24 15:09 PrIzRaKDev

Please amend the commit name to the PR name. We don't use names like "Fix issue-link"

Chaosus avatar Sep 30 '24 15:09 Chaosus

Please amend the commit name to the PR name. We don't use names like "Fix issue-link"

okay, 1 minute.

PrIzRaKDev avatar Sep 30 '24 15:09 PrIzRaKDev

I can't do it. Can you help me?

Please amend the commit name to the PR name. We don't use names like "Fix issue-link"

PrIzRaKDev avatar Sep 30 '24 15:09 PrIzRaKDev

I can't do it. Can you help me?

Please amend the commit name to the PR name. We don't use names like "Fix issue-link"

You can do interactive rebase, edit the comment and then do force push to your remote branch Something like git rebase -i HEAD~1

where 1 is the amount of commit that you have made, then amend the exact commit that you want

minh0722 avatar Sep 30 '24 20:09 minh0722

I am confused as to how the submitted code would work; you are changing the code that happens when you convert from GPU to CPU particles, when the bug is converting from CPU to GPU.

The issue is also more complex than was initially reported in the linked bug report

AtlaStar avatar Oct 01 '24 04:10 AtlaStar