godot
godot copied to clipboard
Add unit tests for `ReflectionProbe`
Added tests for the class Reflection Probe
The tests test the class getters and setters and the function get aabb. This is what was asked in the issue https://github.com/godotengine/godot/issues/43440.
Your pull request contains an unrelated commit (64a08e7 (#97541)). Could you look into removing it? Running the following locally on your fork's branch should do the trick:
git revert --no-edit https://github.com/godotengine/godot/pull/97541/commits/64a08e74f084bb3aa61c72f17a3a2286dfdc60df
git rebase -i HEAD~3
# Edit the file that appears to change the "pick" word on the *last* two lines with "fixup", save and quit.
git commit --amend
# Change the commit message to match the original changes.
# Force push changes (required, since this rewrites history in your fork).
git push -f
See Pull request workflow for more information :slightly_smiling_face:
Thanks for the guide! I think i fixed the commit now, hope this helps! :slightly_smiling_face:
Superseded by:
- https://github.com/godotengine/godot/pull/97818