godotengine
Fix Create new group ok button text in GroupsEditor
Instead of ok_button_text just saying OK in the Create new group dialog, it now says Create.
If it were me, I'd change the OK button text for these three dialogs in one PR instead of three separate PRs.
While the change does make sense, I think it actually makes me a little longer to parse / distinguish the buttons... (especially in this Cancel/Create case) so not sure if this is desired usability-wise. :thinking:
If it were me, I'd change the OK button text for these three dialogs in one PR instead of three separate PRs.
For reference: #97317, #97320.
While the change does make sense, I think it actually makes me a little longer to parse / distinguish the buttons... (especially in this Cancel/Create case) so not sure if this is desired usability-wise. 🤔
Went with that as is already used in other dialogs (Create Node,Attach Node Script, Create Script ...). But can see why it can be hard for someone. Do you think they should change too, and to what?
Went with that as is already used in other dialogs (Create Node,Attach Node Script, Create Script ...).
Oh, you're right!
But can see why it can be hard for someone. Do you think they should change too, and to what?
Nah. Now that you've mentioned other dialogs already being like that I think it was just me overthinking this as I've never noticed such issue for the mentioned other dialogs. Aka seems like I was looking for an issue hard enough to notice a not-really-existant issue. :smile:
So the change makes sense to me! :+1:
BTW such justification ("it's already like that in other dialogs") would be welcomed in the PR description (for the future). :slightly_smiling_face:
If it were me, I'd change the OK button text for these three dialogs in one PR instead of three separate PRs.
For reference: #97317, #97320.
I confirmed that this would be good to do.
@Giganzo Could you merge all three changes in this PR, and close the other two?
Could you merge all three changes in this PR, and close the other two?
Did it myself in the end.
This should be double checked though, does this add more consistency with other dialogs, or creates inconsistency? I'm not sure it's a net improvement overall.