godot icon indicating copy to clipboard operation
godot copied to clipboard

Implement instance uniforms in Compatibility renderer

Open clayjohn opened this issue 1 year ago • 2 comments

Cherrypicked from: https://github.com/godotengine/godot/pull/96814

The infrastructure for this has been in place for a long time, just the final details were needed to make it work.

  • Production edit: This closes https://github.com/godotengine/godot-proposals/issues/6909.

clayjohn avatar Sep 10 '24 19:09 clayjohn

@akien-mga This is a really trivial PR, we can probably go ahead with it without getting a rendering team approval.

clayjohn avatar Sep 27 '24 19:09 clayjohn

✔️ Code looks fine ✔️ Style looks fine ✔️ Tested: Builds, runs, and feature works fine on Windows, behold:

image

With this, I can now switch between Compatibility and Forward+ and this scene works in both.

Docs are here: https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shading_language.html#per-instance-uniforms

mhilbrunner avatar Oct 05 '24 13:10 mhilbrunner

Thanks!

JekSun97 avatar Oct 08 '24 20:10 JekSun97

Thanks so much.

ClintochX avatar Nov 09 '24 07:11 ClintochX

anyone having issues getting instance working on Galaxy s25 ? They don't seem to work for me on S25 brand. So ultra and the none ultra as well. Instance works fine with Pixel and older Samsung devices.

Compatibility - Using Device: Qualcomm - Adreno (TM) 830

TheOathMan avatar Aug 06 '25 17:08 TheOathMan