godotengine
Disallow property keying on read-only animations.
Prevents property keying from being used on resources classified as read-only (ones embedded in other resources and/or imported scenes). It will likewise prevent RESET tracks from being added if the RESET animation is also read-only.
The current behaviour allows users to freely add new keys to an animation, whether its read-only or not. The resource will then become local when the scene is reloaded. It is debatable that user might want to be allowed to break an animation's reference to an externally embedded source, but right now, it done as more of an accidental consequence and no information is presented to user about the implications of breaking the reference to the original animation.
For now, outright disallowing this seems the most consistent design-consistent approach; users can easily still make animations local via the animation library editor if they want, but restricting it will prevent accidental unintentional destructive edits.
Updated this PR which fixes some bugs with reset track creation. As well as checking if the RESET track is read-only, it will also check if the RESET animation already has a matching track so as to remove the redundant checkbox to create a new track.